浏览代码

Add pep8-naming to our python linting

skullY 5 年之前
父节点
当前提交
0ed492978a
共有 4 个文件被更改,包括 8 次插入2 次删除
  1. 5 0
      bin/qmk
  2. 1 1
      lib/python/qmk/cli/doctor.py
  3. 1 1
      lib/python/qmk/tests/test_qmk_errors.py
  4. 1 0
      requirements.txt

+ 5 - 0
bin/qmk

@@ -25,6 +25,11 @@ with open(os.path.join(qmk_dir, 'requirements.txt'), 'r') as fd:
             line = line.split('#')[0]
 
         module = line.split('=')[0] if '=' in line else line
+
+        if module in ['pep8-naming']:
+            # Not every module is importable by its own name.
+            continue
+
         if not find_spec(module):
             print('Could not find module %s!' % module)
             print('Please run `pip3 install -r requirements.txt` to install the python dependencies.')

+ 1 - 1
lib/python/qmk/cli/doctor.py

@@ -39,7 +39,7 @@ def doctor(cli):
                 ok = False
 
     # Determine our OS and run platform specific tests
-    OS = platform.system()
+    OS = platform.system()  # noqa (N806), uppercase name is ok in this instance
 
     if OS == "Darwin":
         cli.log.info("Detected {fg_cyan}macOS.")

+ 1 - 1
lib/python/qmk/tests/test_qmk_errors.py

@@ -1,7 +1,7 @@
 from qmk.errors import NoSuchKeyboardError
 
 
-def test_NoSuchKeyboardError():
+def test_nosuchkeyboarderror():
     try:
         raise NoSuchKeyboardError("test message")
     except NoSuchKeyboardError as e:

+ 1 - 0
requirements.txt

@@ -6,3 +6,4 @@ colorama
 hjson
 nose2
 flake8
+pep8-naming