Преглед изворни кода

[Keyboard] update debounce time on kint boards (#13351)

related to https://github.com/kinx-project/kint/issues/39
related to https://github.com/qmk/qmk_firmware/pull/12626
Michael Stapelberg пре 4 година
родитељ
комит
2b8ad391ae
2 измењених фајлова са 12 додато и 4 уклоњено
  1. 6 2
      keyboards/kinesis/kint2pp/config.h
  2. 6 2
      keyboards/kinesis/kint36/config.h

+ 6 - 2
keyboards/kinesis/kint2pp/config.h

@@ -32,8 +32,12 @@
 #define LED_COMPOSE_PIN C3
 #define LED_PIN_ON_STATE 0
 
-/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
-#define DEBOUNCE 5
+/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the
+ * Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce
+ * algorithm, this debounce latency only affects key releases (not key
+ * presses). */
+#undef DEBOUNCE
+#define DEBOUNCE 20
 
 #define IGNORE_MOD_TAP_INTERRUPT
 

+ 6 - 2
keyboards/kinesis/kint36/config.h

@@ -50,8 +50,12 @@
 /* COL2ROW or ROW2COL */
 #define DIODE_DIRECTION COL2ROW
 
-/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
-#define DEBOUNCE 5
+/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the
+ * Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce
+ * algorithm, this debounce latency only affects key releases (not key
+ * presses). */
+#undef DEBOUNCE
+#define DEBOUNCE 20
 
 #define IGNORE_MOD_TAP_INTERRUPT