Przeglądaj źródła

Fix wrong key when "Music Map" is used with MAJOR_MODE. (#11234)

With MAJOR_MODE (= major scale), keys in one octave is not 12 but 7.
To solve this problem, change divisor number from 12 to 7 at %(Modulo) and /(Division).

NOTE:
The last 12 represents half step keys in one octave for pitch calculation.
Takeshi Nishio 4 lat temu
rodzic
commit
71f067a60e
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      quantum/process_keycode/process_music.c

+ 1 - 1
quantum/process_keycode/process_music.c

@@ -191,7 +191,7 @@ bool process_music(uint16_t keycode, keyrecord_t *record) {
             note = music_starting_note + music_offset + 36 + music_map[record->event.key.row][record->event.key.col];
         } else {
             uint8_t position = music_map[record->event.key.row][record->event.key.col];
-            note             = music_starting_note + music_offset + 36 + SCALE[position % 12] + (position / 12) * 12;
+            note             = music_starting_note + music_offset + 36 + SCALE[position % 7] + (position / 7) * 12;
         }
 #    else
         if (music_mode == MUSIC_MODE_CHROMATIC)