Эх сурвалжийг харах

Modified tmk_core/rules.mk to avoid linking errors (#10728)

* Modified tmk_core/rules.mk to avoid linking errors

Added -fcommon flag to avoid linking errors due to multiple variable definitions. Though this is neither a definitive nor good solution, proper changes and use of extern  keyword to avoid those multiple definitions must be made

* Comment updated
Fabián González Martín 4 жил өмнө
parent
commit
90c7ae70c6

+ 5 - 0
tmk_core/rules.mk

@@ -108,6 +108,10 @@ endif
 CFLAGS += -Wa,-adhlns=$(@:%.o=%.lst)
 CFLAGS += -Wa,-adhlns=$(@:%.o=%.lst)
 CFLAGS += $(CSTANDARD)
 CFLAGS += $(CSTANDARD)
 
 
+# This fixes lots of keyboards linking errors but SHOULDN'T BE A FINAL SOLUTION
+# Fixing of multiple variable definitions must be made.
+CFLAGS += -fcommon
+
 #---------------- Compiler Options C++ ----------------
 #---------------- Compiler Options C++ ----------------
 #  -g*:          generate debugging information
 #  -g*:          generate debugging information
 #  -O*:          optimization level
 #  -O*:          optimization level
@@ -124,6 +128,7 @@ CXXFLAGS += -O$(OPT)
 CXXFLAGS += -w
 CXXFLAGS += -w
 CXXFLAGS += -Wall
 CXXFLAGS += -Wall
 CXXFLAGS += -Wundef
 CXXFLAGS += -Wundef
+
 ifneq ($(strip $(ALLOW_WARNINGS)), yes)
 ifneq ($(strip $(ALLOW_WARNINGS)), yes)
     CXXFLAGS += -Werror
     CXXFLAGS += -Werror
 endif
 endif