瀏覽代碼

Fix regex for parsing rules.mk files

I don't know why it couldn't put it together before... ¯\_(ツ)_/¯
Erovia 5 年之前
父節點
當前提交
d257a98cb8
共有 1 個文件被更改,包括 3 次插入8 次删除
  1. 3 8
      lib/python/qmk/makefile.py

+ 3 - 8
lib/python/qmk/makefile.py

@@ -16,20 +16,15 @@ def parse_rules_mk(file_path):
     Returns:
         a dictionary with the file's content
     """
-    # regex to match lines with comment at the end
+    # regex to match lines uncommented lines and get the data
     # group(1) = option's name
     # group(2) = operator (eg.: '=', '+=')
     # group(3) = value(s)
-    commented_regex = re.compile(r"^\s*(\w+)\s*([\:\+\-]?=)\s*(.*?)(?=\s*\#)")
-    # regex to match lines without comment at the end
-    # group(1) = option's name
-    # group(2) = operator (eg.: '=', '+=')
-    # group(3) = value(s)
-    uncommented_regex = re.compile(r"^\s*(\w+)\s*([\:\+\-]?=)\s*(.*?)(?=\s*$)")
+    rules_mk_regex = re.compile(r"^\s*(\w+)\s*([\?\:\+\-]?=)\s*(\S.*?)(?=\s*(\#|$))")
     mk_content = qmk.path.unicode_lines(file_path)
     parsed_file = dict()
     for line in mk_content:
-        found = commented_regex.search(line) if "#" in line else uncommented_regex.search(line)
+        found = rules_mk_regex.search(line)
         if found:
             parsed_file[found.group(1)] = dict(operator = found.group(2), value = found.group(3))
     return parsed_file